Skip to content

add deny and negative match in authorization policy #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 10, 2020
Merged

add deny and negative match in authorization policy #1222

merged 6 commits into from
Jan 10, 2020

Conversation

@yangminzhu
Copy link
Contributor

@yangminzhu yangminzhu commented Dec 30, 2019 •
edited
Loading

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Dec 30, 2019
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 30, 2019
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 30, 2019
@yangminzhu yangminzhu changed the title add deny support in authorization policy add deny and negative match in authorization policy Dec 30, 2019
@yangminzhu yangminzhu requested a review from liminw December 30, 2019 22:04
@yangminzhu
Copy link
Contributor Author

yangminzhu commented Dec 30, 2019

@liminw Could you do a first round of the review for the PR? thank you.

cc @linsun @louiscryan @smawson @diemtvu @incfly

@yangminzhu yangminzhu marked this pull request as ready for review December 30, 2019 22:07
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Dec 30, 2019
howardjohn
howardjohn reviewed Dec 30, 2019
View reviewed changes
liminw
liminw reviewed Jan 2, 2020
View reviewed changes
liminw
liminw reviewed Jan 2, 2020
View reviewed changes
liminw
liminw approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@liminw liminw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yangminzhu
Copy link
Contributor Author

yangminzhu commented Jan 6, 2020

@louiscryan @smawson @linsun @rshriram @dcberg @geeknoid Could you review the API change, this has been approved by @liminw. Thank you.

@yangminzhu
Copy link
Contributor Author

yangminzhu commented Jan 7, 2020

ping.

@yangminzhu yangminzhu added this to the 1.5 milestone Jan 10, 2020
@yangminzhu
Copy link
Contributor Author

yangminzhu commented Jan 10, 2020

@louiscryan @smawson @linsun @rshriram @dcberg @geeknoid Can someone take a look, I'm trying to get this to 1.5 (cut in ~2 weeks) and all the following changes are blocked by this API change, thank you.

smawson
smawson reviewed Jan 10, 2020
View reviewed changes
smawson
smawson reviewed Jan 10, 2020
View reviewed changes
rshriram
rshriram reviewed Jan 10, 2020
View reviewed changes
Copy link
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am okay with this. Will wait for sven's lgtm though

@istio-testing istio-testing merged commit 660e8ea into istio:master Jan 10, 2020
@yangminzhu yangminzhu deleted the authz-deny branch January 10, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn left review comments

@dcberg dcberg Awaiting requested review from dcberg

@geeknoid geeknoid Awaiting requested review from geeknoid

@linsun linsun Awaiting requested review from linsun

@louiscryan louiscryan Awaiting requested review from louiscryan

+3 more reviewers

@rshriram rshriram rshriram left review comments

@smawson smawson smawson approved these changes

@liminw liminw liminw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

1.5

Development

Successfully merging this pull request may close these issues.

7 participants

@yangminzhu @howardjohn @smawson @rshriram @liminw @googlebot @istio-testing