Skip to content

Remove auth/v1alpha auth policy #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove auth/v1alpha auth policy #1818

wants to merge 2 commits into from

Conversation

jacob-delgado
Copy link
Contributor

These were deprecated and hidden from the docs, but the functionality was removed in 1.6.

@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 13, 2021
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 13, 2021
howardjohn
howardjohn approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! probably the makefile needs an update as well unless it was removed from there?

@jacob-delgado jacob-delgado added the release-notes-none Indicates a PR that does not require release notes. label Jan 13, 2021
@jacob-delgado jacob-delgado requested a review from a team as a code owner January 13, 2021 22:51
@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR needs to be rebased before being merged and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR needs to be rebased before being merged labels Jan 13, 2021
@jacob-delgado jacob-delgado added the do-not-merge/hold Block automatic merging of a PR. label Jan 15, 2021
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jan 17, 2021
@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Mar 9, 2021
@istio-testing istio-testing added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR needs to be rebased before being merged size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 9, 2021
@jacob-delgado jacob-delgado reopened this Mar 9, 2021
@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 9, 2021
@istio-testing
Copy link
Collaborator

@jacob-delgado: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
build_api 74be116 link /test build_api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

nrjpoddar
nrjpoddar approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@nrjpoddar nrjpoddar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jacob-delgado!

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 27, 2021
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label May 14, 2021
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2021-03-09. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 14, 2021
@jacob-delgado jacob-delgado mentioned this pull request May 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@smawson smawson smawson approved these changes

@nrjpoddar nrjpoddar nrjpoddar approved these changes

@dcberg dcberg Awaiting requested review from dcberg

@duderino duderino Awaiting requested review from duderino

@linsun linsun Awaiting requested review from linsun

@louiscryan louiscryan Awaiting requested review from louiscryan

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. do-not-merge/hold Block automatic merging of a PR. lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jacob-delgado @istio-testing @istio-policy-bot @howardjohn @smawson @nrjpoddar