Skip to content

Add DNSDomain as a proxyConfig option, used to be values.yaml only #3234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add DNSDomain as a proxyConfig option, used to be values.yaml only #3234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions mesh/v1alpha1/proxy.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,6 +691,26 @@ message ProxyConfig {
// If IN_MESH, these headers will not be appended to outbound requests from sidecars to services not in-mesh.
MetadataExchangeHeaders metadata_exchange_headers = 6;
}

// dnsDomain is the DNS domain used by Kubernetes Services. Defaults to "cluster.local"
//
// Must match the 'dnsDomain' setting in kubeadm config and clusterDomain setting in kubelet.
// Must match the custom domain set in the external DNS server, if CoreDNS is not used.
//
// Do not set unless you are using a custom DNS domain for your K8S cluster and K8S
// is already set to use this value.
//
// The helm charts use "default.global.proxy.clusterDomain".
//
// Istiod uses this value to generate FQDNs for services. Agent uses this value
// in setting its node ID.
//
// See:
// https://kubernetes.io/docs/reference/config-api/kubelet-config.v1beta1/
// https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta3/#kubeadm-k8s-io-v1beta3-DNS
//
// $hide_from_docs
string DNSDomain = 40;
Copy link
Member

@howardjohn howardjohn Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only controls istio-agent (?) but we need it in istiod as well. What does that mean for usage?

}

message RemoteService {
Expand Down