add missing docs for mixerclient filter config #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
cc @qiwzhang |
geeknoid
approved these changes
Feb 2, 2018
qiwzhang
approved these changes
Feb 2, 2018
douglas-reid
reviewed
Feb 2, 2018
mixer/v1/config/client/quota.proto
Outdated
| @@ -123,6 +123,7 @@ message QuotaSpecBinding { | |||
| // REQUIRED. One or more services to map the listed QuotaSpec onto. | |||
| repeated IstioService services = 1; | |||
|
|
|||
| // QuotaSpecReference defines a reference to a QuotaSpec. | |||
There was a problem hiding this comment.
Can we make this less of a regurgitation?
Maybe something like:
QuotaSpecReference uniquely identifies the QuotaSpec used in the Binding
?
mixer/v1/config/client/auth.proto
Outdated
| @@ -148,6 +149,8 @@ message EndUserAuthenticationPolicySpec { | |||
| repeated JWT jwts = 2; | |||
| } | |||
|
|
|||
| // EndUserAuthenticationPolicySpecReference defines a reference to an | |||
| // an EndUserAuthenticationPolicySpec. | |||
There was a problem hiding this comment.
Can we make this more useful ?
...Ref uniquely identifies a policy being bound to a set of services.
?
douglas-reid
approved these changes
Feb 2, 2018
douglas-reid
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #350