Skip to content

Fix CircleCI error #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Fix CircleCI error #366

merged 1 commit into from
Feb 9, 2018

Conversation

rshriram
Copy link
Member

@rshriram rshriram commented Feb 8, 2018

No description provided.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 8, 2018
@geeknoid geeknoid merged commit 4a77f0b into master Feb 9, 2018
@rshriram rshriram deleted the fixcircleci branch February 13, 2018 19:41
ayj pushed a commit to ayj/api that referenced this pull request Feb 14, 2018
incfly pushed a commit to incfly/api that referenced this pull request Jun 13, 2018
* ApiManager reads init_service_configs in server config

* Added error handling case for no service config

* Used underlying buffer to read config file

* ApiManager reads the service config from server config

* Revert "ApiManager reads the service config from server config"

This reverts commit 7eae288a76bbe83525252bee63cfe7e13c4c9675.
nacx pushed a commit to nacx/api that referenced this pull request Apr 15, 2020
This patch fixes build after make clean, that is by making sure the
javascript client libs are generated.

Signed-off-by: Dhi Aurrahman <[email protected]>

Mirrored from https://github.com/tetrateio/tetrate @ 05b375ddc35d2bc255130ed0449e09095cdd0b45
nacx pushed a commit to nacx/api that referenced this pull request Feb 23, 2022
…ure (istio#366)

When an apply operation is invoked and no error is returned, the invoker has not information if the applied object was created, updated, or unchanged.
To give more information about the apply's operation, we will return:
 - The status of each individual applied object.
 - The applied object itself. The whole object is needed to being able to construct the object's fqn.

A new message called `AppliedObject` is created to encapsulate the status and the applied object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants