Skip to content

automated footer copyright year #16202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

automated footer copyright year #16202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions data/args.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ full_version: "1.25.0"
# The previous Istio version identifier the docs describe, used for upgrade documentation
previous_version: "1.24"

# The year to display in copyright notices
copyright_year: 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the git blame to see why this was added, confirm it was only used in that one place?

It seems like an obvious thing to use "now", which makes it feel like there's a reason - probably so the archive sites have a copyright date of when they were released, and not always "now".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright_year field was first added in PR #3071 . It was originally introduced for the copyright footer and has only been updated since then.


# Controls the incarnation of the site
#
# when preliminary=false and archive=false, we're building for istio.io
Expand Down
2 changes: 1 addition & 1 deletion layouts/partials/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
</ul>

<div class="footer-base">
<span class="footer-base-copyright">&copy; {{ .Site.Data.args.copyright_year }} the Istio Authors.</span>
<span class="footer-base-copyright">&copy; {{ time.Now.Year }} the Istio Authors.</span>

<span class="footer-base-version">
{{ $advisory := (i18n "advisory") }}
Expand Down