Refactor/remove dataview#842
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9758b091b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!cache?.listItems) { | ||
| return undefined; |
There was a problem hiding this comment.
Returning undefined when cache.listItems is absent causes onIndexRequested to drop that file from filesIndexed, so prior entries for the same path are never removed. If a note previously had tracked list items and is edited so CachedMetadata.listItems becomes undefined, stale task/log/plan records remain in the store and continue to appear in views until some other cleanup path runs.
Useful? React with 👍 / 👎.
| {#if $settings.showSubtasksInTaskBlocks && nestedListItems} | ||
| <div | ||
| class="lines-after-first-wrapper" | ||
| {@attach createRenderMarkdownAttachment( | ||
| dedent(deleteProps(getLinesAfterFirst(task.text))).trimStart(), | ||
| task.lines?.slice(1) || [], | ||
| )} | ||
| {@attach createRenderMarkdownAttachment(nestedListItems, [])} |
There was a problem hiding this comment.
The component now only renders nestedListItems for the post-title content, so continuation text on the task itself (the paragraphs produced by toRenderableMarkdown) is dropped. This regresses multiline task display: users with showSubtasksInTaskBlocks enabled will no longer see plain paragraph lines that follow the first list line.
Useful? React with 👍 / 👎.
1 participant
No description provided.