Skip to content

Replaced Android support-v4 library with AndroidX loader library #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

leandroruiz96
Copy link

Replaced deprecated Android support-v4 library with AndroidX loader library

  • Now builds .aar
  • Added .aar plugins for maven
  • Needs Android SDK (just set $ANDROID_HOME environment variable)

@leandroruiz96
Copy link
Author

Leaving this on draft because this will need to setup the Android SDK on the CCI pipeline.

@leandroruiz96 leandroruiz96 marked this pull request as ready for review October 19, 2021 04:01
@fernan88
Copy link

We need this fix too!

@j256
Copy link
Owner

j256 commented Oct 20, 2021

What does this do to the backwards compatibility? @kpgalligan any comments?

@j256
Copy link
Owner

j256 commented Oct 25, 2021

Should I release 2 versions? One with the old android-support and one with AndroidX?

@leandroruiz96
Copy link
Author

That would be helpful for the people who still haven't migrated to AndroidX. But considering that the original Android support library is no longer maintained, I wouldn't keep the support version for much longer.

@fernan88
Copy link

fernan88 commented Nov 3, 2021

Hi @j256, do you have any update on this?

leandroruiz96 and others added 2 commits February 11, 2022 17:26
…brary

- Now builds .aar
- Added .aar plugins for maven
- Needs Android SDK (just set $ANDROID_HOME environment variable)
@nogueirasjorge
Copy link

Hi @j256! every conflict has been resolved for this pull request. Could you take a look at this update for a future merging? Thanks in advance!

@j256
Copy link
Owner

j256 commented Feb 11, 2022

Hey @leandroruiz96 , can you merge up from trunk. I see a lot of duplicate changes were are confusing the diff.

@nogueirasjorge
Copy link

Hey @j256, I've merged up the changes again. So, you will be able to see just the changes related to this merge request.

@j256
Copy link
Owner

j256 commented Feb 17, 2022

How can I test these changes? I'm not up on my Android testing. I'd like to verify that the old version of the generated files work as well as the new.

@nogueirasjorge
Copy link

nogueirasjorge commented Feb 21, 2022

To test this, you will need to package the library and import the ormlite-android.aar generated into an android project. The easiest way to do this is by placing the aar into a libs folder inside the main module in your Android project:

Screen Shot 2022-02-21 at 15 58 21

and adding it in the build.gradle as a dependency:

dependencies { implementation files('./libs/ormlite-android.aar') }

@nogueirasjorge
Copy link

Hi @j256, just to check. Could you test the changes? It'll be really nice to have this merged in a future release.

@bio007
Copy link

bio007 commented Jun 13, 2022

Hi, this would help us a lot as well 👍

@nogueirasjorge
Copy link

Hi @j256, I hope you are doing well. Have you had the chance to review this branch? It'd be very helpful to have it merged.

@dan-ryan
Copy link

I would like to turn off Jetifier, but this library is holding that up. Would be great if this can be merged this in :)

@felipehjcosta
Copy link

+1

@nogueirasjorge
Copy link

Hi @j256 , I really hope you are doing well. Have you had the chance to review this change?. We need to remove jetifier from our application and this change is a must.

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants