-
Notifications
You must be signed in to change notification settings - Fork 27
Support time 1.11 and Win32 2.12 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tfausak could you possibly update this to allow @jacobstanley any chance to merge this PR soon? |
|
Oh, this library doesn't have an upper bound on Line 48 in 3ae1124
So this should Just Work ™️ with |
Shouldn't the title of the PR say "Support time <= 1.12 ..." (looking at the changes to .cabal). Ping @jacobstanley : Can this be merged or triaged? Compilation of |
I fixed 0.5.2 and 0.5.3 on hackage (bound Win32 < 2.12), but a release of 0.5.4 that includes this PR would be nice to have. |
Ping @jacobstanley. |
Any updates here? Since HLS is closing in on GHC 9.2 support, this issue becomes more relevant. |
I think this would close #52 |
This is needed also for hls support for ghc-9.0.2: haskell/haskell-language-server#2567 |
Sent an email to @jacobstanley, hope he could find some time to take a look to this. |
@jacobstanley many thanks! any chance to get this uploaded to hackage to make it available? |
I have just uploaded it unix-compat-0.5.4 Thanks for pinging me ❤️ |
Supporting time 1.11 just needed a bump on the constraint. Supporting Win32 2.12 was slightly more involved since the type signature of
setFileTime
changed. See haskell/win32@7dfe8b3.