Skip to content

Support time 1.11 and Win32 2.12 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

tfausak
Copy link
Contributor

@tfausak tfausak commented May 24, 2021

Supporting time 1.11 just needed a bump on the constraint. Supporting Win32 2.12 was slightly more involved since the type signature of setFileTime changed. See haskell/win32@7dfe8b3.

@Bodigrim
Copy link

Bodigrim commented Oct 5, 2021

@tfausak could you possibly update this to allow Win32-2.13 as well?

@jacobstanley any chance to merge this PR soon?

@tfausak
Copy link
Contributor Author

tfausak commented Oct 5, 2021

c_SetWindowLongPtr (haskell/win32#183) is apparently unused by this library, so supporting Win32-2.13.0.0 should be a simple version bump.

@tfausak
Copy link
Contributor Author

tfausak commented Oct 5, 2021

Oh, this library doesn't have an upper bound on Win32 anyway:

build-depends: Win32 >= 2.5.0.0

So this should Just Work ™️ with Win32-2.13.0.0.

@andreasabel
Copy link
Contributor

andreasabel commented Nov 13, 2021

Shouldn't the title of the PR say "Support time <= 1.12 ..." (looking at the changes to .cabal).

Ping @jacobstanley : Can this be merged or triaged?

Compilation of unix-compat fails under GHC 9.2 atm, even with time-1.9.3:
https://github.com/agda/agda/runs/4199503599?check_suite_focus=true#step:11:2937

@andreasabel
Copy link
Contributor

I fixed 0.5.2 and 0.5.3 on hackage (bound Win32 < 2.12), but a release of 0.5.4 that includes this PR would be nice to have.

@andreasabel
Copy link
Contributor

Ping @jacobstanley.

@fendor
Copy link

fendor commented Dec 29, 2021

Any updates here? Since HLS is closing in on GHC 9.2 support, this issue becomes more relevant.

@jneira jneira mentioned this pull request Jan 1, 2022
@jneira
Copy link

jneira commented Jan 1, 2022

I think this would close #52

@jneira
Copy link

jneira commented Jan 11, 2022

This is needed also for hls support for ghc-9.0.2: haskell/haskell-language-server#2567

@jneira
Copy link

jneira commented Jan 11, 2022

Sent an email to @jacobstanley, hope he could find some time to take a look to this.

@jacobstanley jacobstanley merged commit 7bdf1da into jacobstanley:master Jan 11, 2022
@jneira
Copy link

jneira commented Jan 11, 2022

@jacobstanley many thanks! any chance to get this uploaded to hackage to make it available?

@jacobstanley
Copy link
Owner

I have just uploaded it unix-compat-0.5.4

Thanks for pinging me ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants