Skip to content

JSON file traverse #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2016
Merged

JSON file traverse #206

merged 3 commits into from
Jun 12, 2016

Conversation

jacobwilliams
Copy link
Owner

  • Added traverse method to json_file.
  • Added new methods to get and set the json_core in a json_file.

Fixes #204

core no longer public in json_file (reverts change made in previous commit)
@zbeekman
Copy link
Contributor

The tests failing due to code coverage decreases... we can tweak these in codecov.yml, or add some more tests.

@codecov-io
Copy link

codecov-io commented Jun 12, 2016

Current coverage is 82.50%

Merging #206 into master will increase coverage by 0.10%

@@             master       #206   diff @@
==========================================
  Files             3          3          
  Lines          3017       3035    +18   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2486       2504    +18   
  Misses          531        531          
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by fc322be...6fe76f7

@jacobwilliams
Copy link
Owner Author

I added unit tests for new stuff. Looks like it passes now. I confess I don't really understand the codecov.yml file or how to tweak it!

@jacobwilliams jacobwilliams merged commit 73d046f into master Jun 12, 2016
@jacobwilliams jacobwilliams deleted the json-file-traverse branch June 12, 2016 21:31
@zbeekman
Copy link
Contributor

I confess I don't really understand the codecov.yml file or how to tweak it!

I'm not sure anybody does! lol they really created a dog's breakfast with their last update...

Theoretically you can read about the settings here by clicking on the entries in the example codecov.yml at the bottom of the page... documentation is not super clear, however...

Essentially you can create requirements that e.g., Some global coverage minimum is maintained, and requirements on commits/merges/PRs that the new/changed code meets certain levels of coverage...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants