chore: Bump tsconfig target from es2016 to es2020#3945
Merged
yurishkuro merged 1 commit intoMay 22, 2026
Conversation
Aligns the TypeScript syntax target with Vite's build target (es2020-era browsers). The mismatch was causing tsc to reject valid modern syntax like BigInt literals even though esbuild handles them correctly for the targeted browsers. Fixes jaegertracing#3944 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Yuri Shkuro <github@ysh.us>
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yurishkuro
added
the
changelog:bugfix-or-minor-feature
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3945 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 336 336
Lines 10473 10473
Branches 2747 2747
=======================================
Hits 9513 9513
Misses 833 833
Partials 127 127 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
M-DEV-1
pushed a commit
to M-DEV-1/jaeger-ui
that referenced
this pull request
May 25, 2026
## Summary - Bumps `tsconfig.json` `target` from `es2016` to `es2020` to align with Vite's build target (es2020-era browsers) - Removes the mismatch that caused tsc to reject valid modern syntax (e.g. BigInt literals) even though esbuild handles them correctly for targeted browsers - No impact on browser compatibility — esbuild (via Vite) controls the final output target, not tsc Fixes jaegertracing#3944 ## Test plan - [ ] `npm run lint` passes (tsc-lint included) - [ ] `npm test` passes - [ ] `npm run build` succeeds 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Harizz076
pushed a commit
to Harizz076/jaeger-ui
that referenced
this pull request
Jul 4, 2026
## Summary - Bumps `tsconfig.json` `target` from `es2016` to `es2020` to align with Vite's build target (es2020-era browsers) - Removes the mismatch that caused tsc to reject valid modern syntax (e.g. BigInt literals) even though esbuild handles them correctly for targeted browsers - No impact on browser compatibility — esbuild (via Vite) controls the final output target, not tsc Fixes jaegertracing#3944 ## Test plan - [ ] `npm run lint` passes (tsc-lint included) - [ ] `npm test` passes - [ ] `npm run build` succeeds 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsconfig.jsontargetfromes2016toes2020to align with Vite's build target (es2020-era browsers)Fixes #3944
Test plan
npm run lintpasses (tsc-lint included)npm testpassesnpm run buildsucceeds🤖 Generated with Claude Code