feat(search): Make default lookback configurable; reconstruct lookback from URL timestamps

[yurishkuro]

Which problem is this PR solving?

The Lookback dropdown in the Search form has two related issues:

1. The default value always hardcodes 1h regardless of deployment context. Some deployments (e.g. high-cardinality environments, short-retention backends) want a shorter default like 15m to avoid overwhelming the backend on every page load.

2. When a URL is shared without a lookback param (e.g. from an external system or manually crafted link), the form previously hardcoded '1h' as the selected option, misrepresenting the actual time range that was searched.

maxLookback is already configurable but only controls the upper bound, not the pre-selected default.

Description of the changes

1. Configurable default lookback

Adds search.defaultLookback to the UI config object. When set to a recognized option, it overrides the hardcoded '1h' default used when the lookback cannot be derived from the URL. Invalid values are silently ignored and fall back to '1h'.

Example jaeger-ui.json:

{
  "search": {
    "defaultLookback": "15m"
  }
}

Valid values: "5m", "15m", "30m", "1h", "2h", "3h", "6h", "12h", "24h", "2d", "3d", "5d", "7d", "2w", "3w", "4w", "custom".

2. Reconstruct lookback from URL timestamps

When lookback is absent or invalid in the URL but valid start/end timestamps are present, the lookback is now reconstructed by rounding up to the smallest standard option that covers the full range (or 'custom' when the range exceeds all standard options). The config default is applied only when timestamps are absent or invalid too.

This logic lives in lookbackFromUrlState() in url.ts and is shared by both searchQueryFromUrl() and mapStateToProps via the public lookbackFromUrl() wrapper.

Files changed

• types/config.ts — adds defaultLookback?: string to the search section
• utils/time-range-options.ts — adds asValidLookback() (validates + accepts 'custom') and lookbackFromDuration() helpers; moved from constants/ to utils/
• SearchForm.tsx — reads search.defaultLookback via lookbackFromUrl() + asValidLookback() fallback chain; removes lookback from queryString.parse destructure
• url.ts — adds lookbackFromUrlState() (shared core logic), lookbackFromUrl() (public string wrapper); searchQueryFromUrl delegates to lookbackFromUrlState to avoid double-parsing

How was this change tested?

• time-range-options.test.ts: 4 new tests for lookbackFromDuration
• url.test.js: 5 new tests for searchQueryFromUrl lookback reconstruction
• SearchForm.test.jsx: 2 new tests for mapStateToProps — config default used when no URL lookback, URL lookback takes precedence

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/main/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully: make lint test

AI Usage in this PR

• Moderate: AI helped with code generation

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.13%. Comparing base (cb50cc4) to head (104c1bc).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3973      +/-   ##
==========================================
+ Coverage   91.11%   91.13%   +0.01%     
==========================================
  Files         342      342              
  Lines       10702    10723      +21     
  Branches     2819     2823       +4     
==========================================
+ Hits         9751     9772      +21     
  Misses        826      826              
  Partials      125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

Adds a UI configuration knob to control the default Lookback selection in the Search form, allowing deployments to choose a less expensive default time range than the current hardcoded 1h.

Changes:

• Extends the UI Config type with search.defaultLookback?: string (documented as a Lookback dropdown value).
• Applies search.defaultLookback in SearchForm for initial form values and the Lookback dropdown default.
• Adds unit tests verifying config default behavior and URL precedence, and documents why url.ts retains a hardcoded fallback.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
packages/jaeger-ui/src/types/config.ts	Adds search.defaultLookback to the typed UI config with documentation.
packages/jaeger-ui/src/components/SearchTracePage/url.ts	Documents why URL parsing still falls back to '1h' when lookback is absent.
packages/jaeger-ui/src/components/SearchTracePage/SearchForm.tsx	Reads search.defaultLookback to influence Lookback defaults and initial form state.
packages/jaeger-ui/src/components/SearchTracePage/SearchForm.test.jsx	Adds tests for config-driven default lookback and URL precedence.

Comments suppressed due to low confidence (1)

packages/jaeger-ui/src/components/SearchTracePage/SearchForm.tsx:367

• search.defaultLookback is consumed directly as the Select default/initial value, but it is not validated against the allowed lookbackOptions (and can also be inconsistent with search.maxLookback). If it’s misconfigured (typo, unsupported unit, or a value filtered out by optionsWithinMaxLookback()), AntD Select can render an empty value and submitForm() will compute timestamps from an invalid lookback. Consider normalizing/clamping the configured value: if it’s not in the allowed set (and within the maxLookback range), fall back to DEFAULT_LOOKBACK (or to searchMaxLookback.value).

  const { useOpenTelemetryTerms: useOtelTerms, search } = useConfig();
  const searchMaxLookback: ILookbackOption | undefined = search?.maxLookback;
  const searchAdjustEndTime: string | undefined = search?.adjustEndTime;
  const defaultLookback: string = search?.defaultLookback ?? DEFAULT_LOOKBACK;
  const [formData, setFormData] = useState<Partial<ISearchFormFields>>(() => ({
    service: initialValues?.service,
    operation: initialValues?.operation,
    tags: initialValues?.tags,
    lookback: initialValues?.lookback,
    startDate: initialValues?.startDate,

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

packages/jaeger-ui/src/utils/time-range-options.ts:113

• The PR description lists constants/time-range-options.ts, but the helpers are added in src/utils/time-range-options.ts (and there is no constants/time-range-options.ts in this package). Updating the description/file list would avoid confusion for reviewers and future archeology.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.