Skip to content

Use Go 1.11 in Travis #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2018
Merged

Conversation

isaachier
Copy link
Contributor

No description provided.

Signed-off-by: Isaac Hier <[email protected]>
@jpkrohling
Copy link
Contributor

Two of the CI jobs failed, probably related to Travis connectivity, so, I restarted them. One failed again, in a different step and might be relevant to this PR:

Go fmt, license check, or import ordering failures, run 'make fmt'
./crossdock/services/tracehandler_test.go
./plugin/storage/cassandra/dependencystore/storage.go
./plugin/storage/cassandra/spanstore/writer_test.go
make: *** [lint] Error 1

@isaachier
Copy link
Contributor Author

Oh ya that formatting changes need to be applied. Ill get to that asap.

Signed-off-by: Isaac Hier <[email protected]>
@isaachier
Copy link
Contributor Author

The tests need to be rerun.

@ghost ghost assigned black-adder Sep 9, 2018
@ghost ghost added the review label Sep 9, 2018
@codecov
Copy link

codecov bot commented Sep 9, 2018

Codecov Report

Merging #1053 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1053   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         139     139           
  Lines        6451    6451           
======================================
  Hits         6451    6451
Impacted Files Coverage Δ
...lugin/storage/cassandra/dependencystore/storage.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 774c01b...ac23aa8. Read the comment docs.

@black-adder black-adder merged commit 086fb2b into jaegertracing:master Sep 9, 2018
@ghost ghost removed the review label Sep 9, 2018
@isaachier
Copy link
Contributor Author

Thanks @black-adder. Go 1.11 has an issue in the race detector when calling len on a channel (golang/go#27070). Sarama fails this test repeatedly. IDK how you got tests to run here.

@isaachier isaachier deleted the travis-go-1.11 branch September 9, 2018 18:10
@black-adder
Copy link
Contributor

Gonna roll back until the fix is in

black-adder added a commit that referenced this pull request Sep 9, 2018
yurishkuro pushed a commit that referenced this pull request Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants