Skip to content

fix(storage/v2): Use FindTraceIDsRequest for FindTraceIDs RPC #8603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yurishkuro merged 2 commits into from
May 21, 2026
Merged

fix(storage/v2): Use FindTraceIDsRequest for FindTraceIDs RPC #8603

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf10b9d
fix(storage/v2): Use FindTraceIDsRequest for FindTraceIDs RPC
yurishkuro May 21, 2026
60ba70b
chore(deps): Update jaeger-idl submodule and go.mod to v0.8.0
yurishkuro May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion idl
Open in desktop
Submodule idl updated 1 files
+7 −4 proto/storage/v2/trace_storage.proto
354 changes: 272 additions & 82 deletions internal/proto-gen/storage/v2/trace_storage.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion internal/storage/v2/grpc/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ func (h *Handler) FindTraces(

func (h *Handler) FindTraceIDs(
ctx context.Context,
req *storage.FindTracesRequest,
req *storage.FindTraceIDsRequest,
) (*storage.FindTraceIDsResponse, error) {
foundTraceIDs := []*storage.FoundTraceID{}
for traceIDs, err := range h.traceReader.FindTraceIDs(ctx, toTraceQueryParams(req.Query)) {
Expand Down
2 changes: 1 addition & 1 deletion internal/storage/v2/grpc/handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ func TestHandler_FindTraceIDs(t *testing.T) {
})).Once()
server := NewHandler(reader, writer, depReader)

response, err := server.FindTraceIDs(context.Background(), &storage.FindTracesRequest{
response, err := server.FindTraceIDs(context.Background(), &storage.FindTraceIDsRequest{
Query: &storage.TraceQueryParameters{
ServiceName: "service",
OperationName: "operation",
Expand Down
2 changes: 1 addition & 1 deletion internal/storage/v2/grpc/tracereader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func (tr *TraceReader) FindTraceIDs(
params tracestore.TraceQueryParams,
) iter.Seq2[[]tracestore.FoundTraceID, error] {
return func(yield func([]tracestore.FoundTraceID, error) bool) {
resp, err := tr.client.FindTraceIDs(ctx, &storage.FindTracesRequest{
resp, err := tr.client.FindTraceIDs(ctx, &storage.FindTraceIDsRequest{
Query: toProtoQueryParameters(params),
})
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion internal/storage/v2/grpc/tracereader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func (ts *testServer) FindTraces(

func (ts *testServer) FindTraceIDs(
context.Context,
*storage.FindTracesRequest,
*storage.FindTraceIDsRequest,
) (*storage.FindTraceIDsResponse, error) {
return &storage.FindTraceIDsResponse{
TraceIds: ts.traceIDs,
Expand Down
Loading