[es] Rename NumTraces to SearchDepth in ES v2 dbmodel#8611
Merged
mahadzaryab1 merged 2 commits intoMay 24, 2026
Merged
Conversation
Renames NumTraces int to SearchDepth int inside TraceQueryParameters to align the ES internal dbmodel with the core v2 TraceQueryParameters API definition. This addresses a technical debt item marked with a TODO and fixes all associated references across core packages, readers, and unit tests. Signed-off-by: ayu. <aezyus1@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR aligns the Elasticsearch trace reader query parameter naming by replacing NumTraces with SearchDepth across the DB model, reader logic, and related tests.
Changes:
- Renamed
dbmodel.TraceQueryParameters.NumTracestoSearchDepth. - Updated trace query mapping and defaulting logic to use
SearchDepth. - Adjusted unit tests to construct queries using
SearchDepth.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/storage/v2/elasticsearch/tracestore/reader_test.go | Updates test query params to use SearchDepth instead of NumTraces. |
| internal/storage/v2/elasticsearch/tracestore/reader.go | Maps TraceQueryParams.SearchDepth into DB query params via the new SearchDepth field. |
| internal/storage/v2/elasticsearch/tracestore/core/reader_test.go | Updates core reader tests to set SearchDepth in query parameters. |
| internal/storage/v2/elasticsearch/tracestore/core/reader.go | Renames default constant and applies defaulting + aggregation sizing based on SearchDepth. |
| internal/storage/v2/elasticsearch/tracestore/core/dbmodel/model.go | Renames the field in TraceQueryParameters to SearchDepth. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mahadzaryab1
approved these changes
May 24, 2026
mahadzaryab1
added
the
changelog:refactoring
mahadzaryab1
changed the title
NumTraces to SearchDepth in ES v2 dbmodel
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8611 +/- ##
==========================================
+ Coverage 96.56% 96.57% +0.01%
==========================================
Files 331 331
Lines 17566 17566
==========================================
+ Hits 16963 16965 +2
+ Misses 454 453 -1
+ Partials 149 148 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
via the queue into
jaegertracing:main
with commit May 24, 2026
909a3a5
72 of 73 checks passed
vic-comm
pushed a commit
to vic-comm/jaeger
that referenced
this pull request
Jun 11, 2026
…ing#8611) Renames NumTraces int to SearchDepth int inside TraceQueryParameters to align the ES internal dbmodel with the core v2 TraceQueryParameters API definition. This addresses a technical debt item marked with a TODO and fixes all associated references across core packages, readers, and unit tests. ## Which problem is this PR solving? - Resolves jaegertracing#8601 ## Description of the changes - Renamed `NumTraces` -> `SearchDepth` fields inside the Elasticsearch internal `TraceQueryParameters` struct (`internal/storage/v2/elasticsearch/tracestore/core/dbmodel/model.go`). - Updated the `defaultNumTraces` constant to `defaultSearchDepth` and updated fallback assignment layers inside `internal/storage/v2/elasticsearch/tracestore/core/reader.go`. - Fixed structural field assignment logic within `internal/storage/v2/elasticsearch/tracestore/reader.go`. - Refactored all corresponding broken field references inside the associated `_test.go` suites. ## How was this change tested? - Validated build consistency locally. - Executed unit regression tests via `make test`. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/main/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully: `make lint test` ## AI Usage in this PR (choose one) See [AI Usage Policy](https://github.com/jaegertracing/jaeger/blob/main/CONTRIBUTING_GUIDELINES.md#ai-usage-policy). - [ ] **None**: No AI tools were used in creating this PR - [x] **Light**: AI provided minor assistance (formatting, simple suggestions) - [ ] **Moderate**: AI helped with code generation or debugging specific parts - [ ] **Heavy**: AI generated most or all of the code changes Signed-off-by: ayu. <aezyus1@gmail.com> Signed-off-by: Victor Chidera Obiezue <obiezuechidera@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames NumTraces int to SearchDepth int inside TraceQueryParameters to align the ES internal dbmodel with the core v2 TraceQueryParameters API definition.
This addresses a technical debt item marked with a TODO and fixes all associated references across core packages, readers, and unit tests.
Which problem is this PR solving?
Description of the changes
NumTraces->SearchDepthfields inside the Elasticsearch internalTraceQueryParametersstruct (internal/storage/v2/elasticsearch/tracestore/core/dbmodel/model.go).defaultNumTracesconstant todefaultSearchDepthand updated fallback assignment layers insideinternal/storage/v2/elasticsearch/tracestore/core/reader.go.internal/storage/v2/elasticsearch/tracestore/reader.go._test.gosuites.How was this change tested?
make test.Checklist
make lint testAI Usage in this PR (choose one)
See AI Usage Policy.