Fix __all__ handling (microsoft#908)

* Fix microsoft#668 (partial)

* Tests

* Revert "Tests"

This reverts commit 7ffc9db.

* Partial

* Part 2

* Part 3

* Part 4

* Part 4

* Part 5

* Analysis tests

* Tests

* Tests

* Basic test

* Tests

* Tests

* Tests

* Tests

* Tests

* Linked variables

* Tests

* Tests

* Tests

* Merge issues

* Fix merge issue

* Basic single file

* Handle closed files

* Closed files

* Tests

* Tests

* Fix 454

* Remove references on analysis change

* Rename

* Rename non-user code

* Linter

* Ref fix

* Member expressions

* Linter improvements

* Tests

* Definitions only for LHS

* Add test

* Add null checks and tests

* Null checks

* Fix variable leak in expressions with comprehensions

* Temp

* Fix scope lookup + test

* Handle virtual space

* Better handle nested sequence expression assignments

* More extensive handling of RHS sequences

* PR feedback

* Enable test

* Test stability

* Don't collect references to library modules

* Handle virtual envs

* PR feedback

* null check

* Remove references in all modules

* Add test

* Perf improvement

* Null check in tests

* Store span rather than node

* Fix AST associations with locations

* Handle null nodes

* Temp

* Add AST to nodes

* Variable refs

* Null ref

* Merge issues

* Handle import *

* Undo debug

* Merge issues

* Better handle variable

* Null check

* Better handle nested variables without location

* Fix rename test

* Usings

* Fix merge conflict

* Fix __all__ processing

* Undo temp change

Author: Mikhail Arkhipov

src/Analysis/Ast/Impl/Analyzer/AnalysisWalker.cs

@@ -66,11 +66,11 @@ public override bool Walk(ExpressionStatement node) {
                     return false;
                 case CallExpression callex when callex.Target is NameExpression nex && !string.IsNullOrEmpty(nex.Name):
                     Eval.LookupNameInScopes(nex.Name)?.AddReference(Eval.GetLocationOfName(nex));
-                    return false;
+                    return true;
                 case CallExpression callex when callex.Target is MemberExpression mex && !string.IsNullOrEmpty(mex.Name):
                     var t = Eval.GetValueFromExpression(mex.Target)?.GetPythonType();
                     t?.GetMember(mex.Name).AddReference(Eval.GetLocationOfName(mex));
-                    return false;
+                    return true;
                 default:
                     return base.Walk(node);
             }

src/Analysis/Ast/Impl/Analyzer/Evaluation/ExpressionEval.Collections.cs

@@ -60,7 +60,7 @@ public IMember GetValueFromList(ListExpression expression) {
                 var value = GetValueFromExpression(item) ?? UnknownType;
                 contents.Add(value);
             }
-            return PythonCollectionType.CreateList(Module.Interpreter, contents);
+            return PythonCollectionType.CreateList(Module.Interpreter, contents, exact: true);
         }
 
         public IMember GetValueFromDictionary(DictionaryExpression expression) {
@@ -70,7 +70,7 @@ public IMember GetValueFromDictionary(DictionaryExpression expression) {
                 var value = GetValueFromExpression(item.SliceStop) ?? UnknownType;
                 contents[key] = value;
             }
-            return new PythonDictionary(Interpreter, contents);
+            return new PythonDictionary(Interpreter, contents, exact: true);
         }
 
         private IMember GetValueFromTuple(TupleExpression expression) {
@@ -79,7 +79,7 @@ private IMember GetValueFromTuple(TupleExpression expression) {
                 var value = GetValueFromExpression(item) ?? UnknownType;
                 contents.Add(value);
             }
-            return PythonCollectionType.CreateTuple(Module.Interpreter, contents);
+            return PythonCollectionType.CreateTuple(Module.Interpreter, contents, exact: true);
         }
 
         public IMember GetValueFromSet(SetExpression expression) {
@@ -88,7 +88,7 @@ public IMember GetValueFromSet(SetExpression expression) {
                 var value = GetValueFromExpression(item) ?? UnknownType;
                 contents.Add(value);
             }
-            return PythonCollectionType.CreateSet(Interpreter, contents);
+            return PythonCollectionType.CreateSet(Interpreter, contents, exact: true);
         }
 
         public IMember GetValueFromGenerator(GeneratorExpression expression) {

src/Analysis/Ast/Impl/Analyzer/ModuleWalker.cs

@@ -106,7 +106,6 @@ private void HandleAllAppendExtend(CallExpression node) {
             }
 
             IPythonCollection values = null;
-
             switch (me.Name) {
                 case "append":
                     values = PythonCollectionType.CreateList(Module.Interpreter, new List<IMember> { v }, exact: true);

src/Analysis/Ast/Impl/Types/Collections/PythonCollectionType.cs

@@ -95,7 +95,7 @@ public static IPythonCollection CreateList(IPythonInterpreter interpreter, IArgu
             } else {
                 contents = args.ListArgument?.Values;
             }
-            return CreateList(interpreter, contents ?? Array.Empty<IMember>());
+            return CreateList(interpreter, contents ?? Array.Empty<IMember>(), exact: exact);
         }
 
         public static IPythonCollection CreateList(IPythonInterpreter interpreter, IReadOnlyList<IMember> contents, bool flatten = true, bool exact = false) {

src/LanguageServer/Test/ImportsTests.cs

@@ -536,7 +536,7 @@ def baz(self):
     pass
 " + allCode;
 
-            var appCode = @"
+            const string appCode = @"
 from module1 import *
 
 A().