Skip to content

Conversation

@TheDrawingCoder-Gamer
Copy link

updates to 13.0.2
use slim render for alex character slots
locks some dependency versions to versions back from when this mod was first made

@cloby0
Copy link

cloby0 commented Jun 3, 2024

i dont think this guy is merging prs

@Rafario448
Copy link

Is it possible that I can use your PR Where can I find the updated .nro?

@TheDrawingCoder-Gamer
Copy link
Author

TheDrawingCoder-Gamer commented Jun 4, 2024 via email

@Rafario448
Copy link

Rafario448 commented Jun 4, 2024

You have to compile it yourself with skyline rust. It clean compiles on my machine

On Tue, Jun 4, 2024 at 14:58 Rafario @.> wrote: Is it possible that I can use your PR Where can I find the updated .nro? — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGL466E6JYSZWQXCE6OOYEDZFYE5VAVCNFSM6AAAAABIJA2UEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBYGIYDGMBSGM . You are receiving this because you authored the thread.Message ID: @.>

I'm sorry, I'm not a programmer, I have no clue where even to find tutorials on how to do that. The closest thing to a clue was this https://docs.rs/skyline/latest/skyline/
What program should I use to open this Skyline Rust?

I'm sorry if i'm being annoying asking this, but can you provide the .nro?

@TheDrawingCoder-Gamer
Copy link
Author

TheDrawingCoder-Gamer commented Jun 4, 2024

https://github.com/TheDrawingCoder-Gamer/smash-minecraft-skins/releases/tag/2.0.0 Here's a build from my more advanced branch that supports autodetecting skins.

You have to replace the plugin.nro from normal download and it should work

@Rafario448
Copy link

https://github.com/TheDrawingCoder-Gamer/smash-minecraft-skins/releases/tag/2.0.0 Here's a build from my more advanced branch that supports autodetecting skins.

You have to replace the plugin.nro from normal download and it should work

Thank you very much!

@RedstoneSSB
Copy link

RedstoneSSB commented Jul 26, 2024

https://github.com/TheDrawingCoder-Gamer/smash-minecraft-skins/releases/tag/2.0.0 Here's a build from my more advanced branch that supports autodetecting skins.

You have to replace the plugin.nro from normal download and it should work

What did you do to get this building? I've tried building off your alex and alex-automagic branches, but the build fails with:

rror: failed to run custom build command for `ring v0.16.20 (https://github.com/skyline-rs/ring?branch=0.16.20#59cb1fba)`

Caused by:
  process didn't exit successfully: `/home/steve/Projects/smash-minecraft-skins/target/debug/build/ring-baf1a430a60f18cd/build-script-build` (exit status: 101)
  --- stdout
  OPT_LEVEL = Some(0)
  TARGET = Some(aarch64-skyline-switch)
  OUT_DIR = Some(/home/steve/Projects/smash-minecraft-skins/target/aarch64-skyline-switch/debug/build/ring-8fe225cc2bc87af9/out)
  cargo:rerun-if-env-changed=CC_ENABLE_DEBUG_OUTPUT
  cargo:warning=Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `aarch64-none-elf-gcc` installed?
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some(true)
  CARGO_CFG_TARGET_FEATURE = Some(neon)
  HOST = Some(x86_64-unknown-linux-gnu)
  cargo:rerun-if-env-changed=CFLAGS_aarch64-skyline-switch
  CFLAGS_aarch64-skyline-switch = None
  cargo:rerun-if-env-changed=CFLAGS_aarch64_skyline_switch
  CFLAGS_aarch64_skyline_switch = None
  cargo:rerun-if-env-changed=TARGET_CFLAGS
  TARGET_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None

Not sure how to install that toolchain with rustup, nor does trying to use similar commands to the GitHub Action.

@RedstoneSSB
Copy link

@TheDrawingCoder-Gamer Any word? I'd like to try and update this mod for 13.0.3

@TheDrawingCoder-Gamer
Copy link
Author

i think u have to use cargo skyline? idk

@RedstoneSSB
Copy link

I did when I last tried.

I'm on NixOS, so not sure if something weird is going on with the custom skyline toolchain and non-FHS systems. The ring dep seems to want the target aarch64-none-elf-gcc to be installed, but rustup says no rust-std component exists for it, which cargo-skyline should be using custom std libs when building.

Just curious how you got your build working, because I cloned your fork and ran cargo skyline build, which failed, and cargo skyline update-std didn't fix it. Tried many permutations of updating cargo-skyline, deps, and ring.

Does building the project still work for you?

@TheDrawingCoder-Gamer
Copy link
Author

Yeah it works for me. Maybe try using this Cargo.lock (rename it to remove the .txt) to get my exact libraries?
Cargo.lock.txt

@mm2leaf
Copy link

mm2leaf commented Dec 26, 2024

Hey there-! If it's alright, I'm also looking to get an updated version of this mod for 13.0.3, but I've got no idea where to even start with it. I'd be willing to learn, but I've literally no clue how anything like this works even remotely, I'm god awful at coding anything.

Is there any chance a version for 13.0.3 could be made, or if there could be some instructions on how to actually make it? Again, I'd do it myself but I've got no clue what to do. The project looks very promising with the addition of slim skins (Alex's model) and automatically sorting between the two types, and I'd love to actually use it since I was a huge fan of the original mod, but I couldn't get in touch with the original creator at all so asking here is my best bet. @TheDrawingCoder-Gamer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants