refactor: generic-type-constraint

Src/Coravel.Mailer/MailServiceRegistration.cs

@@ -25,10 +25,10 @@ public static IServiceCollection AddMailer(this IServiceCollection services, ICo
         {
             string mailerType = config.GetValue<string>("Coravel:Mail:Driver", "FileLog");
 
-            var strategies = new Dictionary<string, Action>();
+            var strategies = new Dictionary<string, Action>(StringComparer.OrdinalIgnoreCase);
             strategies.Add("SMTP", () => AddSmtpMailer(services, config));
             strategies.Add("FILELOG", () => AddFileLogMailer(services, config));
-            strategies[mailerType.ToUpper()].Invoke();
+            strategies[mailerType].Invoke();
             return services;
         }
 

Src/Coravel/Events/Dispatcher.cs

@@ -13,8 +13,8 @@ namespace Coravel.Events
     ///  </summary>
     public class Dispatcher : IDispatcher, IEventRegistration
     {
-        private IServiceScopeFactory _scopeFactory;
-        private Dictionary<Type, List<Type>> _events;
+        private readonly IServiceScopeFactory _scopeFactory;
+        private readonly Dictionary<Type, List<Type>> _events;
 
         public Dispatcher(IServiceScopeFactory scopeFactory)
         {
@@ -29,16 +29,11 @@ public Dispatcher(IServiceScopeFactory scopeFactory)
         /// <returns></returns>
         public IEventSubscription<TEvent> Register<TEvent>() where TEvent : IEvent
         {
-            var listeners = new List<Type>();
             var eventType = typeof(TEvent);
 
-            if (this._events.ContainsKey(eventType))
+            if(!this._events.TryGetValue(eventType, out var listeners))
             {
-                listeners = this._events[eventType];
-            }
-            else
-            {
-                this._events.Add(eventType, listeners);
+                this._events.Add(eventType, listeners = new List<Type>());
             }
 
             return new EventSubscription<TEvent>(listeners);
@@ -48,9 +43,8 @@ public IEventSubscription<TEvent> Register<TEvent>() where TEvent : IEvent
         ///  Broadcasts an event to be handled by its subscribed listeners.
         /// </summary>
         /// <param name="toBroadcast"></param>
-        /// <typeparam name="TEvent"></typeparam>
         /// <returns></returns>
-        public async Task Broadcast<TEvent>(TEvent toBroadcast) where TEvent : IEvent
+        public async Task Broadcast(IEvent toBroadcast)
         {
             if (this._events.TryGetValue(toBroadcast.GetType(), out var listeners))
             {
@@ -59,10 +53,11 @@ public async Task Broadcast<TEvent>(TEvent toBroadcast) where TEvent : IEvent
                     await using (var scope = this._scopeFactory.CreateAsyncScope())
                     {
                         var obj = scope.ServiceProvider.GetService(listenerType);
-                        if (obj is IListener<TEvent> listener)
+                        if (obj is IListener listener)
                         {
                             await listener.HandleAsync(toBroadcast);
                         }
+                        // can delete
                         else {
                             // Depending on what assemblies the events, listeners and calling assmebly are - the cast
                             // above doesn't work (even though the type really does implement the interface).

Src/Coravel/Events/Interfaces/IDispatcher.cs

@@ -10,7 +10,6 @@ public interface IDispatcher
         /// <summary>
         /// Dispatches and broadcasts the event to all subscribed listeners.
         /// </summary>
-        /// <typeparam name="TEvent"></typeparam>
-        Task Broadcast<TEvent>(TEvent toBroadcast) where TEvent : IEvent;
+        Task Broadcast(IEvent toBroadcast);
     }
 }

Src/Coravel/Events/Interfaces/IListener.cs

@@ -2,8 +2,17 @@
 
 namespace Coravel.Events.Interfaces
 {
-    public interface IListener<TEvent> where TEvent : IEvent
+    public interface IListener<TEvent> : IListener
+        where TEvent : IEvent
     {
         Task HandleAsync(TEvent broadcasted);
+
+        Task IListener.HandleAsync(IEvent broadcasted)
+             => HandleAsync((TEvent)broadcasted);
+    }
+
+    public interface IListener
+    {
+        internal Task HandleAsync(IEvent broadcasted);
     }
 }

Src/Coravel/Queuing/Interfaces/IQueue.cs

@@ -38,8 +38,7 @@ public interface IQueue
         /// <summary>
         /// Queue an event to be broadcasted.
         /// </summary>
-        /// <typeparam name="TEvent"></typeparam>
-        void QueueBroadcast<TEvent>(TEvent toBroadcast) where TEvent : IEvent;
+        void QueueBroadcast(IEvent toBroadcast);
 
         /// <summary>
         /// Queue an invocable that will be given the payload supplied to this method.

Src/Coravel/Queuing/Queue.cs

@@ -71,7 +71,7 @@ public Guid QueueAsyncTask(Func<Task> asyncTask)
             return job.Guid;
         }
 
-        public void QueueBroadcast<TEvent>(TEvent toBroadcast) where TEvent : IEvent
+        public void QueueBroadcast(IEvent toBroadcast)
         {
             this.QueueAsyncTask(async () => await this._dispatcher.Broadcast(toBroadcast));
         }

Src/Coravel/Scheduling/Schedule/Mutex/InMemoryMutex.cs

@@ -9,10 +9,11 @@ public class InMemoryMutex : IMutex
     {
         private IUtcTime _utcTime;
         private readonly object _lock = new object();
-        private Dictionary<string, MutexItem> _mutexCollection = new Dictionary<string, MutexItem>();
+        private readonly Dictionary<string, MutexItem> _mutexCollection;
 
         public InMemoryMutex() {
             this._utcTime = new SystemUtcTime();
+            _mutexCollection = new Dictionary<string, MutexItem>();
         }
 
         /// <summary>

Src/UnitTests/CoravelUnitTests/Scheduling/Stubs/DispatcherStub.cs

@@ -5,7 +5,7 @@ namespace CoravelUnitTests.Scheduling.Stubs
 {
     public class DispatcherStub : IDispatcher
     {
-        public Task Broadcast<TEvent>(TEvent toBroadcast) where TEvent : IEvent
+        public Task Broadcast(IEvent toBroadcast)
         {
             return Task.CompletedTask;
         }