Fix fast build #60
Merged
Fix fast build #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 860547f. PROBLEM: messes up docker push SOLUTION: remove linker switch NOTE: issues mentioned in 86054 still apply, and will be addressed in this PR.
paulgb
reviewed
Jun 15, 2022
pretentious7
force-pushed
the
fix-fast-build
branch
from
2005b3d to
c61f43f
Compare
PROBLEM: as mentioned in 86054, hot-reloads take around 10s, mostly due to linker. SOLUTION: use mold, this time via a fast_build script that sets the necessary cargo env vars, ensures that mold and clang are installed, and runs cargo build with the correct path for the mold linker. POSSIBLE IMPROVEMENTS: may be a good idea to switch the shell script for a zx script. Also would be nice if `cargo build` automatically ran fast_build.sh as a wrapper if the host and profile are correct (ie. linux host, with dev profile)
pretentious7
force-pushed
the
fix-fast-build
branch
from
c61f43f to
24652e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROBLEM:
as mentioned in 86054, hot-reloads take around 10s, mostly due to
linker.
SOLUTION:
use mold, this time via a fast_build script that sets the necessary
cargo env vars, ensures that mold and clang are installed, and runs
cargo build with the correct path for the mold linker.
POSSIBLE IMPROVEMENTS:
may be a good idea to switch the shell script for a zx script. Also
would be nice if
cargo buildautomatically ran fast_build.sh as awrapper if the host and profile are correct (ie. linux host, with
dev profile)