Add ^19.0.0-rc to @y-sweet/react peer dependencies#338
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![standard-input[bot]](https://avatars.githubusercontent.com/in/1011034?s=60&v=4){kind=small}
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ae345d7 in 4 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. js-pkg/react/package.json:46
- Draft comment:
The change to"react": "^16.8 || ^17 || ^18 || ^19 || ^19.0.0-rc"correctly allows for pre-release versions of React 19, as intended. - Reason this comment was not posted:
Confidence changes required:0%
The change in peerDependencies is correct and aligns with the PR description.
Workflow ID: wflow_Ucy8IE87v1xXuujM
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rolyatmax
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #336 —
^19.0.0actually doesn't match pre-releases, which is what Next.js is including (react@19.0.0-rc-66855b96-20241106).^19.0.0-rcmatches all pre-releases, as confirmed by https://semver.npmjs.com.Also,
^19desugars to^19.0.0so I just removed the extraneous.0.0s.