Improve create-y-sweet-app#340
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
jakelazaroff
force-pushed
the
create-y-sweet-app-2
branch
from
ee502a1 to
b1d6191
Compare
![standard-input[bot]](https://avatars.githubusercontent.com/in/1011034?s=60&v=4){kind=small}
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ee502a1 in 1 minute and 8 seconds
More details
- Looked at
513lines of code in40files - Skipped
10files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. js-pkg/create-y-sweet-app/src/run.js:22
- Draft comment:
Catching all errors and logging them before callinghelp()might not be the best approach. Consider handling specific errors more gracefully. - Reason this comment was not posted:
Confidence changes required:50%
The error handling in the try-catch block is not specific enough. It logs the error and then calls the help function, which might not be the best way to handle all errors. It would be better to handle specific errors more gracefully.
2. js-pkg/create-y-sweet-app/src/run.js:8
- Draft comment:
Thequestionfunction is duplicated incli.jsandrun.js. Consider removing the duplicate inrun.jsand using the one fromcli.js. - Reason this comment was not posted:
Comment looked like it was already resolved.
3. js-pkg/create-y-sweet-app/src/run.js:11
- Draft comment:
TheFRAMEWORKSconstant is defined as aSet, but it is only used for membership checks and listing. Consider using an array instead. - Reason this comment was not posted:
Confidence changes required:30%
TheFRAMEWORKSconstant is defined as aSet, but it is only used for checking membership and listing available frameworks. ASetis not necessary for these operations, and an array would suffice.
Workflow ID: wflow_ZHD5p4y18TbVGXSQ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ce52c7a in 5 seconds
More details
- Looked at
25lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. js-pkg/create-y-sweet-app/src/cli.js:104
- Draft comment:
Fix the typo in the comment.
// store number of lines we just rendered
- Reason this comment was not posted:
Confidence changes required:10%
The comment on line 99 has a typo that should be corrected for clarity.
Workflow ID: wflow_ene7w3KgnvdNz6Hn
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rolyatmax
approved these changes
Nov 25, 2024
rolyatmax
left a comment
rolyatmax
left a comment
Member
There was a problem hiding this comment.
Nice! Love the select() function!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
binsettings and add shebangREADME.mdforcreate-y-sweet-apppackage and framework templates.