Add echo endpoint to server for sync check#356
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 490c304 in 1 minute and 31 seconds
More details
- Looked at
24lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. crates/y-sweet-core/src/doc_connection.rs:186
- Draft comment:
UsingOnceLock::setcan panic if called more than once. Consider usingOnceLock::get_or_initor checking if it's already set to avoid potential panics. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_8TfaEwvtRibAYWTV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
michaelsilver
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is extracted from #353 and includes only the server-side change.
It adds a custom message type that simply echoes back the content it received. Since the server processes messages sequentially, this is a way for a client to confirm that a message has been processed: