Disable lower casing of query string keys #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @benurb Thanks for fixing this issue. You're totally right that query string param names should be case sensitive. I'll write a test case for it and release a new version soon. |
|
Added test case 6e32ecc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
we're using your module and it works great so far. The only thing we noticed is, that it converts query string keys to lower case. That does not conform to RFC2616. A query string
keyandKEYshould be passed as two seperate values to the express/koa server.I created a PR with the changes that work for us. Maybe it helps :)
Keep up the good work 👍
Best regards,
Ben