Brief: Restore code that cleans dynamic syspath at the end of binscript #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In a previous PR, in an attempt to get tests working where packages were being installed into the original syspath instead of a test-local syspath, I removed some code that "fixed" the test but broke binscripts more generally. binscripts are set up with a dynamic syspath hardcoded at the beginning and removed at the end to make sure they can find their dependencies, regardless of JANET_PATH. This restores that behavior. The tests were originally failing since they were running `janet-pm` via `sh/exec` AND `janet-pm` didn't know about the custom JANET_PATH. So the second change here, just to the tests, is to set JANET_PATH to the test-local syspath before running `janet-pm` via `sh/exec` This should also fix the problem seen in janet-lang#248, where `janet-pm` fails after activating a new `env`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In a previous PR #230, in an attempt to get tests working where packages were being installed into the original syspath instead of a test-local syspath, I removed some code that "fixed" the test but broke binscripts more generally.
binscripts are set up with a dynamic syspath hardcoded at the beginning and removed at the end to make sure they can find their dependencies, regardless of JANET_PATH.
This restores that behavior. The tests were originally failing since they were running
janet-pmviash/execANDjanet-pmdidn't know about the custom JANET_PATH.So the second change here, just to the tests, is to set JANET_PATH to the test-local syspath before running
janet-pmviash/execThis should also address the problem seen in #248, where
janet-pmfails after activating a newenv