Add tests for remove#880
Open
E-A-Griffin wants to merge 2 commits into
Open
Conversation
jeaye
requested changes
May 15, 2026
| (testing "pred returning nil keeps the item" | ||
| (is (= '(nil false) (remove identity [nil true false 0 ""])))) | ||
| (is (= #{:b :c :d :e} (into #{} (remove #{:a} #{:a :b :c :d :e})))) | ||
| (is (= #{:b :c :d :e} (into #{} (remove #{:a} #{:a :b :c :d :e}))))) |
Member
There was a problem hiding this comment.
I think a couple of good tests:
- nil collection
- Infinite collection
Collaborator
There was a problem hiding this comment.
Yea, infinite collection is particularly important to ensure it remains lazy.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new core test namespace to cover clojure.core/remove, addressing the missing coverage reported in issue #451.
Changes:
- Introduces
clojure.core-test.removewith transducer and 2-arityremovebehavioral tests. - Adds exception-case coverage for invalid predicate and invalid collection argument types, using portable
p/thrown?assertions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "" | ||
| #"" | ||
| 0 | ||
| [])) |
dgr
suggested changes
May 15, 2026
Collaborator
dgr
left a comment
dgr
left a comment
There was a problem hiding this comment.
Overall, looks good. A couple changes.
| (testing "pred returning nil keeps the item" | ||
| (is (= '(nil false) (remove identity [nil true false 0 ""])))) | ||
| (is (= #{:b :c :d :e} (into #{} (remove #{:a} #{:a :b :c :d :e})))) | ||
| (is (= #{:b :c :d :e} (into #{} (remove #{:a} #{:a :b :c :d :e}))))) |
Collaborator
There was a problem hiding this comment.
Yea, infinite collection is particularly important to ensure it remains lazy.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #451