Math epic - Part 1#763
Open
shantanu-sardesai wants to merge 10 commits into
Open
Conversation
jeaye
requested changes
May 9, 2026
shantanu-sardesai
force-pushed
the
issues/636-math-epic
branch
2 times, most recently
from
f16d26f to
7fcb947
Compare
shantanu-sardesai
added a commit
to shantanu-sardesai/jank
that referenced
this pull request
May 10, 2026
Resolves the following thread(s): - jank-lang#763 (comment).
shantanu-sardesai
added a commit
to shantanu-sardesai/jank
that referenced
this pull request
May 10, 2026
Resolves the following thread(s): - jank-lang#763 (comment).
shantanu-sardesai
added a commit
to shantanu-sardesai/jank
that referenced
this pull request
May 10, 2026
Resolves the following thread(s): - jank-lang#763 (comment).
shantanu-sardesai
added a commit
to shantanu-sardesai/jank
that referenced
this pull request
May 10, 2026
Resolves the following thread(s): - jank-lang#763 (comment).
shantanu-sardesai
force-pushed
the
issues/636-math-epic
branch
from
c7eb4a7 to
a94fcf5
Compare
shantanu-sardesai
added a commit
to shantanu-sardesai/jank
that referenced
this pull request
May 10, 2026
Resolves the following thread(s): - jank-lang#763 (comment).
shantanu-sardesai
added a commit
to shantanu-sardesai/jank
that referenced
this pull request
May 10, 2026
Resolves the following thread(s): - jank-lang#763 (comment).
shantanu-sardesai
force-pushed
the
issues/636-math-epic
branch
from
a94fcf5 to
1ee6961
Compare
jeaye
requested changes
May 10, 2026
shantanu-sardesai
added a commit
to shantanu-sardesai/jank
that referenced
this pull request
May 13, 2026
Resolves the following thread(s): - jank-lang#763 (comment).
Resolves the following thread(s): - jank-lang#763 (comment).
Resolves the following thread(s): - jank-lang#763 (comment).
Resolves the following thread(s): - jank-lang#763 (comment).
shantanu-sardesai
force-pushed
the
issues/636-math-epic
branch
from
d31177b to
254ec28
Compare
jeaye
requested changes
May 13, 2026
|
|
||
| bool real::equal(object const &o) const | ||
| { | ||
| if(is_nan(this) || is_nan(&o)) |
Member
There was a problem hiding this comment.
This is UB, since we need detail::untagged for raw pointers, due to the recent NaN boxing changes. Please read the big comment block in oref.hpp for details.
We need it for both this and &o. Most likely, this will just crash right now.
Also, we shouldn't use is_nan for this, since that would require building an object_ref, visiting that, and then actually checking isnan. Since we have data already, let's just check directly. Arithmetic operations are one of the most important parts in the jank runtime to keep fast, so keep that in mind. That also means we could use isnan and avoid a duplicate visit on o if we do it later in the fn.
Member
There was a problem hiding this comment.
On second thought, why is this not working by default?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires a Clojure test suite repoint (jank-lang/clojure-test-suite#875). Done.Brings us to 125 of 231 tests. Goal is to get to 145, covering all "math"
clojure.corefunctions with tests in the test suite.