You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks!
But I'm afraid I'll have to bother you again: Please exclude the dist files (/scrollmagic) from the pr, as they are only updated when a new version is released.
note to self: I should probably make this more clear in contributing.md
hey, thanks.
So I noticed this breaks the tests, which can't be a good sign.
I played around a little and noticed that it works, when I add "scrollmagic": "ScrollMagic" at line 76 in dev/tests/main.js.
Unfortunately my experience with require or webpack aren't great, but I doubt this would be the right way to go about this, since the whole point of this was to make it work without additional configurations.
Do have any Idea why the tests may fail?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amend the AMD references so that the library plugins can be used without any webpack config changes.