This repository was archived by the owner on Dec 28, 2020. It is now read-only.
GetUserPaymentRequest expects ISO-8601 Zulu #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Jochem, I managed to reproduce this (and I am working on tests :)). Yes, creating a new datetime object feels a bit dirty, but I think it is nice that we do not change the input objects. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ->format('c') does produce an ISO-8601 string as the documentation states it requires, but in reality as the example states, it expects a ISO-8601-Zulu string, so using this will produce an invalid input error.
Creating a new datetime object feels a bit dirty, but sadly the setTimezone() function does not exist on the DateTimeInterface and I didn't want to change the method contract.