Let Flask manage its own request contexts #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcomo
force-pushed
the
fix/request-contexts
branch
from
bcbfd99 to
3bf7473
Compare
|
👍 |
jcox-dev
pushed a commit
to ONSdigital/ras-party
that referenced
this pull request
Dec 19, 2017
jcox-dev
pushed a commit
to ONSdigital/ras-party
that referenced
this pull request
Dec 19, 2017
Remove dependency on ras-common-utils * Use config objects and environment variables over yaml * Simplify public website URL builder * Stop passing config object around helper functions * Tidying up string formatting * Use config object for alembic migrations * Add cfenv to inject Cloudfoundry service dependency config variables * Pin flask-testing to pre 0.7.0 to work-around missing app context jarus/flask-testing#108
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't manage the context stack in the test setup / teardown. Instead, let Flask handle it. This fixes the issue where global and request context was being reused on subsequent test client requests within the same test case.
I'm a bit concerned that there are some people relying on the fact that the context exists in the setup method for things like attaching global context. While its not a good practice, I wouldn't want to break others test suites with this change.
Fixes #105