#1002 identical params (revised) #1543
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aram names do not conflict with user-defined param names
…param names do not conflict with user-defined param names
|
Closing, since #2021 took care of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1002 identical params (revised)
Proposed by @TrevorBurnham
Milestone 1.1.3
Throws a SyntaxError if two parameters share the same name. As satyr points out, this brings CoffeeScript's params in line with use strict under the ES5 spec.
Original Pull Request #1531
Diff of previous patch and this version
_Revised_
scopeimmediately so that compiler-generated param names don't conflict with user-defined param names.({},_arg)->was causing errors in the previous patch since the compiler generating the param name_argfor{}(thanks @michaelficarra)