Skip to content

Add Integrations section to docs #5334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Conversation

danielbayley
Copy link
Contributor

@danielbayley danielbayley marked this pull request as draft October 16, 2020 21:27
@danielbayley danielbayley marked this pull request as ready for review October 16, 2020 21:27
@GeoffreyBooth
Copy link
Collaborator

This is a good start! I think we should try to include as many high-quality ones as we can find. Like I’m sure there’s something for Webpack. Probably for Rollup, Parcel, etc.

Maybe group by topic? Like Linters, Build Tools, etc. Framework integrations is another category, like the Meteor Atmosphere package (I maintain that one), the Ember one, I’m sure there are others.

@danielbayley danielbayley force-pushed the docs branch 2 times, most recently from e511957 to f14b214 Compare October 18, 2020 13:54
@danielbayley danielbayley changed the title WIP: Add Integrations section to docs Add Integrations section to docs Oct 18, 2020
@danielbayley
Copy link
Contributor Author

@GeoffreyBooth Ok, I added those and more… and also updated the Wiki to match 👍

That's as much as I can/have time to find at the moment… Iv'e checked 'Allow edits by maintainers', so feel free to pick up the baton if you want to add more… Otherwise it should be pretty much ready to merge?

@GeoffreyBooth
Copy link
Collaborator

Just picking this up. I discovered that CoffeeLint has been revived in a new, actively maintained fork: https://coffeelint.github.io/ cc @helixbass.

@GeoffreyBooth
Copy link
Collaborator

@danielbayley I organized the integrations categories similarly to the Resources section, where they appear as subsections. This lets us add links for them in the sidebar. I also added Integrations to the top navbar, and a few links in the CoffeeScript 2 and transpilation sections.

Any notes on this or should I merge it in?

@edemaine
Copy link
Contributor

FWIW, I read this over, and it looks good!

In checking the links I noticed https://marketplace.visualstudio.com/items?itemName=crisward.cjsx, with source at https://github.com/crisward/cjsx . This might be a path forward to fixing syntax highlighting in vscode and in atom.

@GeoffreyBooth
Copy link
Collaborator

This might be a path forward to fixing syntax highlighting in vscode and in atom.

For JSX, you mean? Literate syntax is also horribly broken.

@danielbayley
Copy link
Contributor Author

I discovered that CoffeeLint has been revived in a new, actively maintained fork: https://coffeelint.github.io/ cc @helixbass.

@GeoffreyBooth Which fork is that?

@danielbayley
Copy link
Contributor Author

danielbayley commented Nov 29, 2021

Any notes on this or should I merge it in?

@GeoffreyBooth Nice! Yeah sure, merge away…

p.s The links under https://coffeescript.org#resources are broken in the current deployment, as they try to create a new page…

@GeoffreyBooth
Copy link
Collaborator

p.s The links under https://coffeescript.org#resources are broken in the current deployment, as they try to create a new page…

Can you be more specific? The links in the sidebar work for me, and the links under Resources go to external sites as expected (like for the GitHub repo etc.).

@GeoffreyBooth GeoffreyBooth merged commit 726c085 into jashkenas:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants