Description
This is to capture the discussion regarding which way is defaulting to "up" on each board. Specifically, as part of PR #213, "up" was defined to use 64u - hour
(etc.). See commit 0702b26, file map.cpp
.
However, IIRC, the original branches used different values for "up" when defining the clock's location for 3/6/9/12. The issue tracks the review of the following two functions, back to the original (per-product) branches:
drawAnalogClock()
drawSpiralAnalogClock()
The branches in question are:
-
1628-rings
-- Map.h used255 - hour
-
kraken64
-- Map.h used255 - hour
-
parallel
-- N/A, map.h did not exist in that branch -
fibonacci256
-- Map.h used64 - hour
-
fibonacci512mini
-- Map.h used255 - hour
-
fibonacci128
-- Map.h used255 - hour
-
fibonacci64
-- Map.h used255 - hour
-
fibonacci32mini
-- Map.h used255 - hour
As can be see, every branch calculated "up" as 255 - hour
, with the exception of Fibonacci256
. Only Fibonacci256
calculated it as the currently-checked-in code does (using 64u - hour
). As an aside, it would likely be more correct to use 256u - hour
... casting to uint8_t
to cause angle to remain in range [0..255] ... for the other products.
This leaves only one question:
- Decide how to fix this, or have regressions in all boards other than Fibonacci256