Pin Node to LTS 24 everywhere Node is provisioned#7
Merged
Conversation
Node 26 cannot require() the extensionless yargs 16 entry file that lerna 5 depends on. Pin the release environment to nodejs 24 and tighten engines.node so yarn fails fast with a clear error instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0148E6HYk5ARogwKjfHsKge8
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the
docs/environment.ymlnodejs pin: Node 26 cannotrequire()the extensionless yargs 16 entry file that lerna 5 depends on, so every environment that runsjlpmneeds Node <25.This PR contains the two changes this session was able to push:
docs/source/dev_release.md: pinnodejs=24.*in the release conda environment — it uses the same conda-forge channel that handed ReadTheDocs Node 26, so the next release would hit the identical lerna/yargs crash.package.json: tightenengines.nodefrom>=14to>=18 <25— Yarn 3 enforces this, so anyone building locally on Node 26 gets an immediate clear error instead of the crypticrequire is not defined in ES module scopecrash.Missing piece (needs manual apply): the same pin for CI. The credentials available to this session lack the
workflowOAuth scope, so changes to.github/workflows/*could not be pushed. A patch addingactions/setup-node@v6with Node 24 to every job that runsjlpm(build, devinstall, lint, packaging, and the docs/js/spec/ui jobs in tests.yml) is attached in the session; apply it withgit amonto this branch. Without it, CI keeps using whatever Node the GitHub runner image ships (currently ≤24, which is the only reason Actions stayed green while RTD broke).🤖 Generated with Claude Code
https://claude.ai/code/session_0148E6HYk5ARogwKjfHsKge8
Generated by Claude Code