Provide better support for toolchains for JVM projects #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> * What went wrong: > Execution failed for task :greeter.toolchain:compileJava. > > Cannot specify --release via `CompileOptions.compilerArgs` when using `JavaCompile.release`.
Gradle 6.6 has no toolchain support, but has javaCompile.options.release property.
using Java 17 breaks the build in GitHub Actions workflow, because Java 17 has more strict control on the Java module.
|
Thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle 6.7+ provides the Toolchains for JVM projects, which makes it possible to specify which Java we use to compile the project. refs #187
Currently gradle-modules-plugin has two potential problems around this toolchain feature:
--releaseoption viajavaCompile.options.releaseproperty, and it conflicts with the--releaseoption set by this plugin. Fixed by the commit 6163723JavaToolchainSpecinstead ofJavaVersion.current(). Fixed by the commit 68ed16fBased on the "Testing locally published plugin" guideline, I've confirmed that problems reproduced by the newly added test project have been resolved by these two commits.
Thanks for checking my PR! 🙌