add non-advanced boolean indexing support #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also don't sub-sample indexing tests (run them all) fixes #166
|
I ran the internal tests, and they pass! |
|
Thanks @mattjj -- much appreciated. |
JehandadKhan
referenced
this pull request
in ROCm/jax
Oct 9, 2024
add non-advanced boolean indexing support GitOrigin-RevId: 041ef32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also don't sub-sample indexing tests (run them all)
fixes #166
This PR adds basic boolean indexing support but does not add advanced indexing support with booleans. Let's wait for advanced indexing with bools (and bool/int mixtures) to be requested before we implement it, since advanced indexing is tricky and that use case seems rare. (I'd rather not page it back into my brain!) There's also an easy workaround for experts, which is just to use
onp.whereto create int indices.