Convert extras names to lowercase #342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts the extra names in the package's
extras_require
to lowercase, working around pypa/pip#4617.Motivation and Context
For example, even with the latest pip,
pip install django-setup-tools[SMS]
will not installtwilio
, even though it should.How Has This Been Tested?
Tested by installing
.[sms]
, and by confirming that installing.[SMS]
continues to do what it did before.Screenshots (if appropriate):
N/A
Types of changes
Checklist:
My change requires a change to the documentation.(Onlyphonenumbers
andphonenumberslite
seem to be mentioned, which are already lowercase.)I have updated the documentation accordingly.I have added tests to cover my changes.