Skip to content

Conversation

@DerDreschner
Copy link
Contributor

This pull request handles the case when a UID contains non-ASCII characters by handling the underlying UnicodeDecodeError. To avoid code duplication, I handle them the same way as when the original event contains no UID at all (AttributeError as None has no .encode() function).

Fixes #128

@codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (97c73ba) to head (36699f3).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage   91.79%   91.86%   +0.06%     
==========================================
  Files           4        4              
  Lines         378      381       +3     
  Branches      100       99       -1     
==========================================
+ Hits          347      350       +3     
  Misses         13       13              
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DerDreschner DerDreschner merged commit 8434545 into jazzband:master Jan 17, 2025
4 checks passed
@DerDreschner DerDreschner deleted the fix/non-ascii-uid branch January 17, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnicodeDecodeError when parsing ical with non-ASCII characters in UID

1 participant