-
-
Notifications
You must be signed in to change notification settings - Fork 78
feat: type annotations #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
==========================================
- Coverage 92.05% 91.93% -0.12%
==========================================
Files 4 4
Lines 390 397 +7
Branches 97 99 +2
==========================================
+ Hits 359 365 +6
Misses 14 14
- Partials 17 18 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It highlights the issue fixed in #162. |
|
@BoboTiG are you planning on continuing this? would love to use the type annotations in my own project :) |
|
@BoboTiG if not, let me know, I might like to pick this up for you :) |
|
@lev-blit go ahead, I won't have much time in coming days anyway. |
|
care to give me permission to write to your fork? or I can open a new PR from my fork |
|
That's done :) |
|
Thanks! is there anything else that needs to be done here for this to be merged? (besides reviewing this PR of course :)) |
|
@BoboTiG is there still work to be done here? or can this be merged & published? 🤞🏼 |
|
It's good on my end. But I'm not a maintainer here, maybe @eigenmannmartin could help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds type annotations throughout the codebase to improve type safety and developer experience. The changes also include removal of unused imports and minor code improvements.
- Adds comprehensive type annotations to all functions, methods, and class attributes
- Removes unused imports and reorganizes import statements
- Updates test assertions to use string literals instead of integers for better type consistency
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_icalparser.py | Removes unused date import and reorganizes imports |
| test/test_icalevents.py | Reorders imports and fixes test assertions to use string comparisons |
| test/test_icaldownload.py | Removes unused imports, adds Path testing, and fixes typos |
| icalevents/icalparser.py | Adds comprehensive type annotations and imports future annotations |
| icalevents/icalevents.py | Adds type annotations and reorganizes imports |
| icalevents/icaldownload.py | Adds type annotations and modernizes exception handling |
| MANIFEST.in | Adds py.typed file inclusion for type checking support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Also removed unused imports.