Skip to content

Conversation

@BoboTiG
Copy link
Member

@BoboTiG BoboTiG commented Feb 5, 2025

Also removed unused imports.

@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

❌ Patch coverage is 98.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.93%. Comparing base (eacbe3d) to head (5f5ce34).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
icalevents/icalparser.py 98.07% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   92.05%   91.93%   -0.12%     
==========================================
  Files           4        4              
  Lines         390      397       +7     
  Branches       97       99       +2     
==========================================
+ Hits          359      365       +6     
  Misses         14       14              
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BoboTiG
Copy link
Member Author

BoboTiG commented Feb 5, 2025

It highlights the issue fixed in #162.

@lev-blit
Copy link
Contributor

@BoboTiG are you planning on continuing this? would love to use the type annotations in my own project :)

@lev-blit
Copy link
Contributor

@BoboTiG if not, let me know, I might like to pick this up for you :)

@BoboTiG
Copy link
Member Author

BoboTiG commented Sep 12, 2025

@lev-blit go ahead, I won't have much time in coming days anyway.

@lev-blit
Copy link
Contributor

care to give me permission to write to your fork? or I can open a new PR from my fork

@BoboTiG
Copy link
Member Author

BoboTiG commented Sep 12, 2025

That's done :)

@lev-blit
Copy link
Contributor

Thanks! is there anything else that needs to be done here for this to be merged? (besides reviewing this PR of course :))

@lev-blit
Copy link
Contributor

@BoboTiG is there still work to be done here? or can this be merged & published? 🤞🏼

@BoboTiG
Copy link
Member Author

BoboTiG commented Sep 26, 2025

It's good on my end. But I'm not a maintainer here, maybe @eigenmannmartin could help.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds type annotations throughout the codebase to improve type safety and developer experience. The changes also include removal of unused imports and minor code improvements.

  • Adds comprehensive type annotations to all functions, methods, and class attributes
  • Removes unused imports and reorganizes import statements
  • Updates test assertions to use string literals instead of integers for better type consistency

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/test_icalparser.py Removes unused date import and reorganizes imports
test/test_icalevents.py Reorders imports and fixes test assertions to use string comparisons
test/test_icaldownload.py Removes unused imports, adds Path testing, and fixes typos
icalevents/icalparser.py Adds comprehensive type annotations and imports future annotations
icalevents/icalevents.py Adds type annotations and reorganizes imports
icalevents/icaldownload.py Adds type annotations and modernizes exception handling
MANIFEST.in Adds py.typed file inclusion for type checking support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@eigenmannmartin eigenmannmartin merged commit ba11972 into jazzband:master Sep 26, 2025
13 checks passed
@eigenmannmartin
Copy link
Member

Thank you for your contribution @BoboTiG and @lev-blit 💯 🥳

@BoboTiG BoboTiG deleted the feat-types branch September 26, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants