Fix can't compare offset-naive and offset-aware datetimes error #70
Conversation
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
- Coverage 84.86% 83.03% -1.84%
==========================================
Files 4 4
Lines 337 330 -7
Branches 79 79
==========================================
- Hits 286 274 -12
- Misses 27 31 +4
- Partials 24 25 +1
Continue to review full report at Codecov.
|
| def test_str(self): | ||
| self.eventA.start = datetime(year=2017, month=2, day=3, hour=12, minute=5) | ||
| self.eventA.end = datetime(year=2017, month=2, day=3, hour=15, minute=5) | ||
| self.assertEqual('2017-02-03 12:05:00+00:00: Event A (ended)', str(self.eventA)) |
There was a problem hiding this comment.
I can't see how this actually tests your proposed change. You don't test direct comparison, just the string representations.
There was a problem hiding this comment.
The bug reported in #69 is that str(event) fails for all-day events, which use naive datetime objects. This tests str(event) which is where the patch is and the bug occurs. The test added here fails in master and no longer fails with this patch. The error was introduced by #66 which enforces that all_day events do not have any timezone associated with them and use naive datetimes, so no code using event.start/end may assume tz-aware datetime objects for comparison.
There was a problem hiding this comment.
Oh, I see now.
For some reason I missed that this was in the __str__-method when I reviewed it the first time.
There was a problem hiding this comment.
Thanks for the pointer in the right direction @minrk.
I’ve approved and merged this now, I can unfortunately not release new versions to pypi as I don’t have the credentials so we’ll have to wait for @irgangla to get this released.
|
any chance this will get pushed to pypi anytime soon? |
|
I am still waiting for access rights - sorry @SkiTheSlicer |
…set-datetimes-error Fix can't compare offset-naive and offset-aware datetimes error
5 participants
Fixes Issue #69
Testing
Remove the new code in
icalevents/icalparser.pyand run tests, the new test should fail. Put the code back and the test should pass.