Skip to content

Conversation

@eigenmannmartin
Copy link
Member

@eigenmannmartin eigenmannmartin commented Mar 28, 2021

Issue: office 365 recurring all day events not working.

closes #71
closes #56
closes #54
closes #12
closes #45

includes/based on #79

  • respects transparency

Sorry for the two prs. Hope this pr holds up to your standards 😉

@eigenmannmartin eigenmannmartin changed the title reccuring all day events Reccuring all day events Mar 28, 2021
@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #80 (e77f41f) into master (fee7f42) will increase coverage by 1.82%.
The diff coverage is 100.00%.

❗ Current head e77f41f differs from pull request most recent head 8441aff. Consider uploading reports for the commit 8441aff to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   85.04%   86.87%   +1.82%     
==========================================
  Files           4        4              
  Lines         341      358      +17     
  Branches       81       90       +9     
==========================================
+ Hits          290      311      +21     
+ Misses         27       25       -2     
+ Partials       24       22       -2     
Impacted Files Coverage Δ
icalevents/icalparser.py 87.59% <100.00%> (+2.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fee7f42...8441aff. Read the comment docs.

@eigenmannmartin eigenmannmartin force-pushed the f/reccuring-all-day-events branch from 0da4949 to 6aa12a2 Compare March 29, 2021 21:59
Copy link
Member

@Hultner Hultner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice, thanks for the hard work! 💯

I noted some minor things you might want to change or add comments elaborating why we're doing things we are doing.

@eigenmannmartin eigenmannmartin requested a review from Hultner May 24, 2021 22:12
@eigenmannmartin
Copy link
Member Author

@Hultner Can I ask you to review the changes made?
Thank you so much for your time and effort!

@Hultner
Copy link
Member

Hultner commented Sep 6, 2021

@Hultner Can I ask you to review the changes made?
Thank you so much for your time and effort!

Sorry for slow response, I were quite busy with getting things in order before vacations, and then summer happen. But I'm back at work now.

Copy link
Member

@Hultner Hultner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Looks much simple after your second revision :)
I just commited my suggested formatting change.
Will merge when (if) CI passes.

@Hultner
Copy link
Member

Hultner commented Sep 7, 2021

Looks like the pipeline newer executed :/

@eigenmannmartin Should I just merge it anyway or should we wait until we’ve moved to GH-actions?

@eigenmannmartin
Copy link
Member Author

I think we can wait for the gh actions to work :-)

@Hultner
Copy link
Member

Hultner commented Sep 8, 2021

k we can wait for the gh actions to work :-)

Will do :)

@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #80 (5c9a839) into master (dd3dad6) will increase coverage by 1.99%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   85.04%   87.04%   +1.99%     
==========================================
  Files           4        4              
  Lines         341      355      +14     
  Branches       81       92      +11     
==========================================
+ Hits          290      309      +19     
+ Misses         27       22       -5     
  Partials       24       24              
Impacted Files Coverage Δ
icalevents/icalparser.py 87.83% <87.50%> (+2.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd3dad6...5c9a839. Read the comment docs.

@eigenmannmartin eigenmannmartin merged commit cafa805 into jazzband:master Oct 17, 2021
capuanob pushed a commit to ennamarie19/icalevents that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment