OpenSSL only if feature networking is set.

[dok-net]

This fixes #141 to not include OpenSSL if there's no networking selected.

[dok-net]

This alone doesn't turn off bulding the tests in the submodule vendor/tartanllama/expected, which takes a very long time. Any ideas?

mkdir Release && cd Release
cmake -DCMAKE_BUILD_TYPE=Release -DLIBCORO_FEATURE_NETWORKING=OFF -DLIBCORO_BUILD_TESTS=OFF ..
cmake --build .

[jbaldwin]

Ah yeah I missed this, thanks for opening a PR. I'll need to think on the tests, but maybe that part can just be disabled as well, I think it's just making a unique SSL cert per run.

[dok-net]

@jbaldwin I've added the actual cmake line I was using, I've disabled tests anyway. See how the expected lib builds their tests, anyway. What about C++23 previews, can the expected submodule get ignored for those already, and if, how?

[jbaldwin]

Can you open an issue for the expected lib building tests when tests are disabled? Its a bug in the build system for sure, it might affect the other vendor deps as well

[jbaldwin]

We can use the expected vendor for c++20 and for c++23 use the stdlib version, its possible via cmake to detect the c++ version and only include the vendor one if its < c++23 basically. I would make that as a different issue as well. Realistically I think targeting c++20 for this library indefinitely makes the most sense though, but lets pickup new features if the user is using a new version!

[jbaldwin]

I'm not exactly sure I can add a commit to your fork's PR so I just opened another PR here with the additions to make the tests work properly:

#144

[dok-net]

The cmake configure step still probes for all the networking related APIs.
Edit: This seems to no longer be the case after the latest changes to this PR.

[dok-net]

Can the c-ares be excluded, depending on the networking feature selection?

[dok-net]

I'm not exactly sure I can add a commit to your fork's PR so I just opened another PR here with the additions to make the tests work properly:

#144

I've included your changes into my PR branch.

[dok-net]

Lots of "catch-2" build steps still occur, though.

[jbaldwin]

Yes, I think that should be fixed on the other PR here #143, this is just removing openssl with LIBCORO_FEATURE_NETWORKING=OFF. Trying to keep them distinct commits since they are different issues.

[dok-net]

I'm not merging the pending PRs and pushing, just have it all at once in my work tree and it's not completely there, just yet.

[dok-net]

@jbaldwin This PR includes your branch origin/openssl_only_feature_networking completely, and finishes the remaining issue with "c-ares". Please review, it's ready to merge from my side.