Skip to content

Allow to disable OpenSSL separately if networking is included.#149

Merged
jbaldwin merged 5 commits intojbaldwin:mainfrom
dok-net:opt_ssl
Jun 17, 2023
Merged

Allow to disable OpenSSL separately if networking is included.#149
jbaldwin merged 5 commits intojbaldwin:mainfrom
dok-net:opt_ssl

Conversation

@dok-net
Copy link
Contributor

@dok-net dok-net commented Jun 5, 2023

I found that it's necessary for some targets to omit the SSL support. This is a plain patch with #ifdefs throughout the code.

@dok-net
Copy link
Contributor Author

dok-net commented Jun 5, 2023

I think the TCP echo and HTTP server examples could use some explaining in regard to their worker model.

@jbaldwin
Copy link
Owner

jbaldwin commented Jun 5, 2023

This is a great change, I really like the idea of splitting out SSL from networking. I'm probably not going to be around much this week (vacation) so likely will take a look at it next week.

@dok-net
Copy link
Contributor Author

dok-net commented Jun 12, 2023

The latest commit, in my drive to support embedded targets with partial C++ standard library support, adds the option to en/dis-able all features requiring std::mutex and friends.
@jbaldwin I see that coro::when_all() works without std::mutex. Why is there no coro::when_any()? I haven't looked the code yet, obviously.

@jbaldwin
Copy link
Owner

I've taken a cursory look at this and it looks about right on my phone but I'd like to do a deeper dive (hopefully tomorrow) with a proper screen 😄

Hadn't gotten around to a coro::when_any, but it would be a great addition! I think it might require a cancellation of the tasks that didn't complete first so the library might need to introduce a cancellation token type. It would be dependent upon the users tasks checking for it and stopping execution though.

…ecially because there are exported outward to containing application project.
@jbaldwin
Copy link
Owner

I think the only thing missing is updating the readme-template with the new options, can you add that in please?

@jbaldwin
Copy link
Owner

Doesn't seem to have updated the readme from the githook... We'll get it on the next commit.

@jbaldwin jbaldwin merged commit 6a83046 into jbaldwin:main Jun 17, 2023
@dok-net dok-net deleted the opt_ssl branch June 18, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants