Fix: Move platform-agnostic files outside of LIBCORO_FEATURE_THREADING#175
Fix: Move platform-agnostic files outside of LIBCORO_FEATURE_THREADING#175jbaldwin merged 7 commits intojbaldwin:mainfrom
LIBCORO_FEATURE_THREADING#175Conversation
53b1b52 to
c6bf58e
Compare
|
Do you want me to merge in the Is there anything else to do on this PR? |
|
Generally whatever works best, I usually only squash and rebase into main so it's a singular commit in the final git log. |
|
Looks like you merged main in successfully -- thanks! Do you need anything else from me on this PR? I'm excited to get this merged; I think this will get us to successful builds on XCode and MSVC. I'll do some more testing/cleanup after the merge. |
|
I was planning on merging this tonight, but I did take one last look at it and I do think some of the test files can probably be moved outside of the feature flag pretty easily by switching the tests from |
…tform-dependant io_scheduler.
…depend on LIBCORO_FEATURE_THREADING.
…depend on LIBCORO_FEATURE_THREADING. However, this makes the test run a LOT slower.
This implements the suggestion in #170.