Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Owner
|
Awesome, thank you for pushing this, I'll take a look through it as soon as I can. |
jbaldwin
approved these changes
Feb 21, 2024
Owner
|
Sorry for the delay, I caught a nasty bug and have been under the weather. This looks awesome, thank you for adding it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This PR includes Conan as part of the CI execution, it will install external dependencies via Conan, then, build the project as usual.
I added 4 jobs:
I added Debug because was using Debug that I detected that last error related to the cmake option 👀
It will use GCC 11 + CXX_STANDARD 20 to any build, including Conan packages.
You check the build result in my fork: https://github.com/uilianries/libcoro/actions/runs/7913723780?pr=3
closes #258