Merged
Conversation
jbaldwin
approved these changes
May 24, 2025
Owner
jbaldwin
left a comment
jbaldwin
left a comment
There was a problem hiding this comment.
Really like the idea of the perfect() call, nice way to give a sensible default but also let the user choose specifically if they want to.
jbaldwin
requested changes
May 24, 2025
jbaldwin
approved these changes
May 25, 2025
Owner
|
Would you mind rebasing or merging main into this branch so it's up to date, once passing again I'll get it merged! |
dobord
force-pushed
the
feature/default-executor
branch
from
856dc4e to
3810073
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a common default executor for use both in the library (e.g. libcoro) and in code that uses libcoro