Skip to content

[CLOUD-2598] update jvm args#24

Open
vbusch wants to merge 1 commit into
jboss-container-images:amq-broker-71-devfrom
vbusch:jvm-settings
Open

[CLOUD-2598] update jvm args#24
vbusch wants to merge 1 commit into
jboss-container-images:amq-broker-71-devfrom
vbusch:jvm-settings

Conversation

@vbusch
Copy link
Copy Markdown
Contributor

@vbusch vbusch commented Jun 6, 2018

  • leave the gc from the cct scripts
  • remove the gc that gets added by artemis
  • remove the min and max memory settings from artemis. Using the rations from cct scripts.

Other args added by artemis are:
-XX:+PrintClassHistogram -XX:+AggressiveOpts -XX:+UseFastAccessorMethods -Dhawtio.realm=activemq -Dhawtio.offline="true" -Dhawtio.role=admin -Dhawtio.rolePrincipalClasses=org.apache.activemq.artemis.spi.core.security.jaas.RolePrincipal -Djolokia.policyLocation=${ARTEMIS_INSTANCE_URI}/etc/jolokia-access.xml -Djon.id=amq

Other args added by cct scripts are:
-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap -XX:+UseParallelOldGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:MaxMetaspaceSize=100m -XX:+ExitOnOutOfMemoryError

Signed-off-by: Vanessa Busch vbusch@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

- leave the gc from the cct scripts
- remove the gc that gets added by artemis
- remove the min and max memory settings from artemis.  Using the rations from cct scripts.

Other args added by artemis are:
-XX:+PrintClassHistogram   -XX:+AggressiveOpts -XX:+UseFastAccessorMethods -Dhawtio.realm=activemq  -Dhawtio.offline="true" -Dhawtio.role=admin -Dhawtio.rolePrincipalClasses=org.apache.activemq.artemis.spi.core.security.jaas.RolePrincipal -Djolokia.policyLocation=${ARTEMIS_INSTANCE_URI}/etc/jolokia-access.xml -Djon.id=amq

Other args added by cct scripts are:
-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap -XX:+UseParallelOldGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:MaxMetaspaceSize=100m -XX:+ExitOnOutOfMemoryError

Signed-off-by: Vanessa Busch <vbusch@redhat.com>
Copy link
Copy Markdown

@RoddieKieley RoddieKieley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to me that this does what it says, which I believe were the recommended things to be changed via the associated CLOUD-2598 issue.


function removeArtemisDefaultGcAndMemSettings() {
#Use the memory and gc set calculated from cct_module, removing the ones that conflict
sed -i "s/-XX:+UseG1GC/ /" broker/etc/artemis.profile
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the $AMQ_HOME variable missing here in path to profile file?

gaohoward pushed a commit that referenced this pull request Sep 7, 2021
Issue #24 The command 'ps' is not installed which is used in drain.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants