Fix mini-card close cleanup and confirm popover placement

[jcanizalez]

Summary

• keep the close confirmation popover inside the viewport and flip it above the trigger when needed
• remove sessions from the UI immediately when closing so dead mini cards do not linger
• add a small position helper test for the new popover placement logic

Testing

• yarn vitest run tests/popover-position.test.ts
• yarn eslint src/renderer/components/ConfirmPopover.tsx src/renderer/components/AgentCard.tsx src/renderer/components/FocusedTerminal.tsx src/renderer/components/TabView.tsx src/renderer/lib/popover-position.ts src/renderer/lib/terminal-close.ts src/main/pty-manager.ts tests/popover-position.test.ts

[Copilot]

Pull request overview

This PR improves session-close UX and confirmation popover behavior by (1) centralizing terminal close/cleanup so sessions disappear from the UI immediately and (2) adding viewport-aware positioning logic for confirmation popovers (including flipping when needed).

Changes:

• Add a shared closeTerminalSession helper to immediately remove sessions from UI and request backend termination.
• Introduce calculatePopoverPosition to clamp/flip popover placement within the viewport and wire it into ConfirmPopover.
• Add Vitest coverage for the new popover positioning helper.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/popover-position.test.ts	Adds unit tests for horizontal clamping and vertical flip behavior.
src/renderer/lib/terminal-close.ts	New shared close helper + pending-close tracking used by exit handler.
src/renderer/lib/popover-position.ts	New pure helper to compute popover top/left and placement within viewport constraints.
src/renderer/components/TabView.tsx	Switches tab close flow to use closeTerminalSession.
src/renderer/components/ProjectSidebar.tsx	Switches sidebar session close flow to use closeTerminalSession.
src/renderer/components/FocusedTerminal.tsx	Switches focused session close flow to use closeTerminalSession.
src/renderer/components/ConfirmPopover.tsx	Uses viewport-aware positioning and adds flip + max width constraints.
src/renderer/components/AgentCard.tsx	Switches mini-card close flow to use closeTerminalSession.
src/renderer/App.tsx	Uses consumePendingTerminalClose to handle close-intent exit cleanup.
src/main/pty-manager.ts	Ensures a terminal-exit IPC event is emitted even if the PTY is already missing.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[jcanizalez]

Addressing review

[jcanizalez]

Review Summary

All 3 Copilot review comments have been addressed:

1. ConfirmPopover.tsx — closest('button') anchor issue — Fixed in b17be7a. Now uses a dedicated <span ref={anchorRef}> wrapper instead of walking up with closest("button").

2. App.tsx — Double removeTerminal call — Already guarded at line 165 with if (state.terminals.has(id)), preventing redundant re-renders.

3. ConfirmPopover.tsx — Stale anchorRect on scroll/resize — Fixed. anchorRef stores the actual DOM element, and handleViewportChange re-reads getBoundingClientRect() via readAnchorRect() on every scroll/resize.

Merge Conflict

The PR has a merge conflict in src/renderer/App.tsx. The conflict is trivial — main added three unused variables (_terminals, _activeProject, _taskCount) that should be dropped. Rebase onto main and resolve by keeping HEAD's version (without the _ prefixed vars).