feat: Fix CI: Update mssql-tools installation for Ubuntu 24.04#86
Merged
feat: Fix CI: Update mssql-tools installation for Ubuntu 24.04#86
Conversation
Member
|
@tangyang9464 @imp2002 please review |
|
|
Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI error in mssql-tools installation
Fix CI: Update mssql-tools installation for Ubuntu 24.04
Nov 14, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 73.33% 73.33%
=======================================
Files 3 3
Lines 90 90
Branches 26 26
=======================================
Hits 66 66
Misses 13 13
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #85
CI failing on mssql-tools installation because workflow uses Ubuntu 16.04 packages on ubuntu-latest (now Ubuntu 24.04), causing msodbcsql17 post-install script to fail with exit code 127.
Changes
ubuntu/16.04/prod→ubuntu/22.04/prod(22.04 packages are compatible with 24.04)mssql-tools→mssql-tools18(includes ODBC Driver 18 with proper TLS support)apt-key addwith/etc/apt/trusted.gpg.d/ACCEPT_EULA=Yand-yflags-Cflag to sqlcmd (required for ODBC Driver 18)Original prompt
This section details on the original issue you should resolve
<issue_title>[bug] fix CI error</issue_title>
<issue_description>See: https://github.com/jcasbin/jdbc-adapter/actions/runs/19366024059/job/55409257411