ALL the operators #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...uh this is a lot. This might be kinda silly. Ternary is an operator, but that's not included because of ":". typeof, in, void, they're operators, but they're also keywords, so i'm not changing those either.
|
Oh, your pr is pulled. So I'll just make a new PR at the main repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that your PR says "add comparison operators", but i'm trying to fix atom/tree-sitter-javascript, which really needs all the operators.
I don't think making a new pull request is the right action here, because yours already exists.
Ternary is an operator, but that's not included because of
:typeof, in, void, they're operators, but they're also keywords, so i'm not changing those either.
Visually the positions of
&&and--were changed.