Update serverSetup.ts | Add shebang to Bash install script for compatibility#184
Open
vadrif-draco wants to merge 4 commits intojeanp413:masterfrom
Open
Update serverSetup.ts | Add shebang to Bash install script for compatibility#184vadrif-draco wants to merge 4 commits intojeanp413:masterfrom
vadrif-draco wants to merge 4 commits intojeanp413:masterfrom
Conversation
This should extend support for linux servers whose default shell is not compatible with the embedded shell script
Co-authored-by: Adam C. Stephens <2071575+adamcstephens@users.noreply.github.com>
vadrif-draco
changed the title
Author
|
Any updates on this? I believe it's a very simple fix for a relatively important issue for anyone whose remote machine logon shell isn't compatible with the script... |
GitMensch
reviewed
Jan 22, 2025
Contributor
GitMensch
left a comment
GitMensch
left a comment
There was a problem hiding this comment.
LGTM - but.. is the "env" binary guaranteed to be available in this place everywhere?
|
Simple fix for #182 ? |
|
Just installed a packaged version of the current patch-1 branch in codium, and I still have the same error when reading the install script on the remote machine... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should extend support for linux servers whose default shell is not compatible with the embedded shell script